Return correct HTTP code if context creation fails #2093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrLoh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
Any idea when this will be merged? I think this is useful functionality to expose through graphql. |
|
Hey... This PR seems to have gone a bit stale, so I've resubmitted as #2269 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a proposal to fix #1709 in cases, where apollo already returns a 400 response, to handle the default AuthenticationError and ForbiddenError with fitting HTTP status codes. It doesn't make sense, that these errors set a status code, when thrown from a resolver, since partial data might still be returned in that case, but when the context creation fails, Apollo might as well return a more meaningful status code.
TODO: